search

paws-r / paws

Paws, a package for Amazon Web Services in R
https://www.paws-r-sdk.com
Other
313 stars 37 forks source link

Service endpoint #685

Closed DyfanJones closed 10 months ago

DyfanJones commented 10 months ago

Remove comments before for loop. Addresses issue highlighted in #667

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (93f6f46) 84.11% compared to head (33268f5) 84.14%. Report is 3 commits behind head on main.

:exclamation: Current head 33268f5 differs from pull request most recent head ee11603. Consider uploading reports for the commit ee11603 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #685 +/- ## ========================================== + Coverage 84.11% 84.14% +0.02% ========================================== Files 201 201 Lines 14437 14515 +78 ========================================== + Hits 12144 12213 +69 - Misses 2293 2302 +9 ``` [see 12 files with indirect coverage changes](https://app.codecov.io/gh/paws-r/paws/pull/685/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DyfanJones commented 10 months ago

I believe the new test ini file should cater for most scenarios https://github.com/paws-r/paws/blob/7c10b6bfeb99e30974748c36ded79ddc9967ba2b/paws.common/tests/testthat/data_ini

When I looked into the package ini it didn't handle nested content at all and it could falter on some comments (specially if it had space infront).

On the bright side the new read_ini seems to run better than the old method and the ini package (reading in the test data_ini file). image