Closed DyfanJones closed 10 months ago
It seems like we are getting some good performance compared to the M.ini
package https://github.com/DyfanJones/M.ini (a simple rcpp wrapper around the mINI header only C++ library).
However I am not sure how well my wrapper is (I am guessing it could do with some optimisations). Plus I am not sure how performant mINI is in general.
All modified lines are covered by tests :white_check_mark:
Comparison is base (
3446ff3
) 84.12% compared to head (0c2b38b
) 84.10%.:exclamation: Current head 0c2b38b differs from pull request most recent head 081b8da. Consider uploading reports for the commit 081b8da to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I believe this is the fastest I can get
read_ini
function without going full c++.We have some decent performance now with roughly ~500us to read in the test data_ini compared to ~3ms. This should help with any extra calls to the config files we need to make.