search

paws-r / paws

Paws, a package for Amazon Web Services in R
https://www.paws-r-sdk.com
Other
313 stars 37 forks source link

remove repeat processes #690

Closed DyfanJones closed 10 months ago

DyfanJones commented 10 months ago

I believe this is the fastest I can get read_ini function without going full c++.

We have some decent performance now with roughly ~500us to read in the test data_ini compared to ~3ms. This should help with any extra calls to the config files we need to make.

image

DyfanJones commented 10 months ago

It seems like we are getting some good performance compared to the M.ini package https://github.com/DyfanJones/M.ini (a simple rcpp wrapper around the mINI header only C++ library).

image

However I am not sure how well my wrapper is (I am guessing it could do with some optimisations). Plus I am not sure how performant mINI is in general.

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (3446ff3) 84.12% compared to head (0c2b38b) 84.10%.

:exclamation: Current head 0c2b38b differs from pull request most recent head 081b8da. Consider uploading reports for the commit 081b8da to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #690 +/- ## ========================================== - Coverage 84.12% 84.10% -0.03% ========================================== Files 201 67 -134 Lines 14524 4837 -9687 ========================================== - Hits 12218 4068 -8150 + Misses 2306 769 -1537 ``` [see 135 files with indirect coverage changes](https://app.codecov.io/gh/paws-r/paws/pull/690/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.