search

paws-r / paws

Paws, a package for Amazon Web Services in R
https://www.paws-r-sdk.com
Other
313 stars 37 forks source link

cache read_ini results #692

Closed DyfanJones closed 10 months ago

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (a9be055) 84.11% compared to head (0de9d9a) 84.11%.

:exclamation: Current head 0de9d9a differs from pull request most recent head 471e12c. Consider uploading reports for the commit 471e12c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #692 +/- ## ========================================= Coverage 84.11% 84.11% ========================================= Files 67 201 +134 Lines 4840 14533 +9693 ========================================= + Hits 4071 12224 +8153 - Misses 769 2309 +1540 ``` [see 135 files with indirect coverage changes](https://app.codecov.io/gh/paws-r/paws/pull/692/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paws-r)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DyfanJones commented 10 months ago

Just for completeness, as expected caching drastically improves the performance.

image

I am really happy with this, as we can include more service setting from the .aws/config (https://github.com/paws-r/paws/issues/667) without affecting the overall performance.