Fix warnings/lints in pax

paxdotdev / pax

User interface engine with an integrated vector design tool, built in Rust

https://www.pax.dev/

Apache License 2.0

466 stars 23 forks source link

Fix warnings/lints in pax #183

Closed DanielJoyce closed 5 months ago

DanielJoyce commented 5 months ago

Just a minor cleanup.

I did notice there wasn't a rustfmt set, so there may be some changes to header format or extra lines inserted.

Feel free to ignore, but defining the line widths and pax format rules would ease accepting fixes.

Also making it so warnings become failures helps keep the code clean.

samuelselleck commented 5 months ago

Hi Daniel,

You're right that we should make this a part of the PR/release flow! Setting up linting rules is a good idea as well.

Many of the warning fixes in this PR overlaps with already opened PRs, and so most likely doesn't make sense to merge on it's own. Specifically the one regarding private ImageData was fixed in another already open PR (by me) that makes image_map field private instead of ImgData public.