search

paxdotdev / pax

User interface engine with an integrated vector design tool, built in Rust
https://www.pax.dev/
Apache License 2.0
420 stars 21 forks source link

Windows Fixes + LLM old functions removal #271

Closed samuelselleck closed 2 days ago

github-actions[bot] commented 5 days ago

Deployment preview ready! :rocket:

You can view this deployment at: https://staging.pax.dev/271

samuelselleck commented 5 days ago

Don't merge this just yet - found another issue

github-actions[bot] commented 5 days ago

Deployment preview ready! :rocket:

You can view this deployment at: https://staging.pax.dev/271

samuelselleck commented 5 days ago

Should be ready to merge now! 👍

samuelselleck commented 5 days ago

One sec - need to verify template works

github-actions[bot] commented 5 days ago

Deployment preview ready! :rocket:

You can view this deployment at: https://staging.pax.dev/271

github-actions[bot] commented 5 days ago

Deployment preview ready! :rocket:

You can view this deployment at: https://staging.pax.dev/271

samuelselleck commented 5 days ago

Should be good now! :)

github-actions[bot] commented 5 days ago

Deployment preview ready! :rocket:

You can view this deployment at: https://staging.pax.dev/271

warfaj commented 5 days ago

don't merge, debugging a stickiness issue.

warfaj commented 5 days ago

nvm! can merge.

We found a stickiness issue around the cartridge.tera files. Changes between them weren't being reflected between rebuilds when nothing else was changed. We narrowed it down to being due to macro caching. This is new post the .pax removal refactor because we now read the cartridge.partial.rs snippet at macro creation time which doesn't rerun if the macros dependencies don't change.

zackbrown commented 2 days ago

Thanks for tackling this, @samuelselleck !