Update action to Node v20?

jbwharris commented 5 months ago

I just tried this and got an error about needing to upgrade to Node 20 from 16. Are you planning on updating it?

paxha commented 5 months ago

This is warning, not error. if you can upgrade you can open a PR.

Henriquecsh commented 1 month ago

I'm also receiving an error, it's no longer an alert.

paxha commented 1 month ago

v4 added.

Henriquecsh commented 1 month ago

Thank you

Henriquecsh commented 1 month ago

I don't have success with v4.

paxha commented 1 month ago

try v4.0

paxha commented 1 month ago

          - name: cPanel Deploy using API Token
            uses: paxha/cpanel-deploy@v4.0

jbwharris commented 1 month ago

I keep getting this error when running this action. Any idea what I might be doing wrong here?


Run paxha/cpanel-deploy@v4.0
Starting deployment...
baseUrl: ***:2083/execute/
Deployment finished successfully
Branch main updated successfully
deploy: true
TypeError: Cannot read properties of null (reading 'task_id')
    at /home/runner/work/_actions/paxha/cpanel-deploy/v4.0/dist/index.js:33338:63
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
/home/runner/work/_actions/paxha/cpanel-deploy/v4.0/dist/index.js:33357
                        throw new Error(error);
                              ^

Error: TypeError: Cannot read properties of null (reading 'task_id')
    at /home/runner/work/_actions/paxha/cpanel-deploy/v4.0/dist/index.js:33357:31
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Node.js v20.13.1

paxha commented 1 month ago

can you share your cpanel.yml file?

jbwharris commented 1 month ago

@paxha https://github.com/jbwharris/scrobblerad.io/blob/main/.github/workflows/cpanel-deploy.yml

I've double checked all my secrets. I don't get why it's messing up. I've tried yours and this one https://github.com/pinkasey/cpanel-deploy-action and get the same issue.

paxha commented 1 month ago

it means the issue is in CPanel's apis. Because when the package is developed it was working fine.

paxha / cpanel-deploy

Update action to Node v20? #1