search

payara / Payara

Payara Server is an open source middleware platform that supports reliable and secure deployments of Java EE (Jakarta EE) and MicroProfile applications in any environment: on premise, in the cloud or hybrid.
http://www.payara.fish
Other
883 stars 305 forks source link

Bug Report: When a file is inserted into a project using file upload, it mounts temporary files, but they are not deleted/FISH-8311 #6545

Open romulometaprime opened 9 months ago

romulometaprime commented 9 months ago

Brief Summary

I have noticed corrections made in recent years when using fileupload, Ex: #6020, #5231. However, when upgrading my project from payara 5 to payara 6 I noticed that in payara 6, temporary files are generated within payara/glassfish/domains/myDomain/generated/jsp/myapplication/. However, such files are never deleted. I use the Primefaces framework and even opened a problem with their communities, but they verified that it was an issue to be resolved by payara, as follows: Issue Primefaces #11342.

Expected Outcome

That the temporary files generated by fileupload are deleted as soon as the request is completed, avoiding undue consumption of computing resources.

Current Outcome

Whenever a file is inserted using fileupload, several temporary files are generated, but they are being accumulated in the directory: payara/glassfish/domains/myDomain/generated/jsp/myapplication/.

Reproducer

Below is an example project for verification: Project

Operating System

Ubuntu 22.04.3 LTS

JDK Version

java 17.0.8 2023-07-18 LTS

Payara Distribution

Payara Server Full Profile

felixif commented 9 months ago

Hello @romulometaprime,

I have verified the issue with the reproducer provided in the PrimeFaces issue (the link here sent me to the Primefaces repository). Indeed these .tmp files do not go away, and I can understand that, for a large application, polluting the server space with all these temporary files can lead to the unnecessary use of the storage space. I have raised an internal issue with the code FISH-8311, which will be picked up and solved by the Engineering team in due course. Thank you for your bug report!

Best regards, Felix Ifrim

rdelaplante commented 3 months ago

When vulnerability scanners are run regularly against applications deployed in Payara, this directory can build up tens of thousands of .tmp files. I noticed this on a server running Payara 6.2024.4