payara / Payara

Payara Server is an open source middleware platform that supports reliable and secure deployments of Java EE (Jakarta EE) and MicroProfile applications in any environment: on premise, in the cloud or hybrid.
http://www.payara.fish
Other
879 stars 300 forks source link

FISH-8728 Refine RE to allow host in jdwp agent address #6724

Closed pzygielo closed 1 month ago

pzygielo commented 3 months ago

Description

This is a fix.

Related:

Testing

New tests

New UT added for host part in address.

Testing Performed

$ uzip -q -d /tmp/payara appserver/distributions/payara/target/payara.zip
$ /tmp/payara/payara6/glassfish/bin/asadmin start-domain --debug=true
Waiting for domain1 to start .............
Successfully started the domain : domain1
domain  Location: /tmp/payara/payara6/glassfish/domains/domain1
Log File: /tmp/payara/payara6/glassfish/domains/domain1/logs/server.log
Admin Port: 4848
Debugging is enabled.  The debugging port is: 9009
Command start-domain executed successfully.

Testing Environment

Documentation

https://github.com/payara/Payara/blob/26c504bb440432cfaa40e425730650945a23c823/nucleus/admin/server-mgmt/src/main/manpages/com/sun/enterprise/admin/servermgmt/cli/start-domain.1#L68-L70

Notes for Reviewers

pzygielo commented 3 months ago

Converted to draft as it does not work in some cases.