payara / Payara

Payara Server is an open source middleware platform that supports reliable and secure deployments of Java EE (Jakarta EE) and MicroProfile applications in any environment: on premise, in the cloud or hybrid.
http://www.payara.fish
Other
881 stars 304 forks source link

FISH-8855-Added Auto name for deployment group #6784

Closed NotedSalmon closed 3 months ago

NotedSalmon commented 3 months ago

FISH-8855 added auto name for deployment group

Description

I have made changes to the strings.properties file so that instead of saying autoname instance, it says autoname instance/deployment group so it saves creating another autoname.help text.

Changed dgNew.jsf to include the checkbox button and changed the commands block for the new button so that the Deployment group label does not show as required (as autoname is an option) and if autoname is selected, it will use the same code as the instance autoname.

Important Info

Blockers

Testing

New tests

Testing Performed

Built and ran the server, made sure it was working. Tested auto naming multiple deployment groups and instances to make sure both worked correctly. Tested leaving everything blank to display error messages and tested setting own name + ticking the box to make sure that if the label is populated, it will default the name to that even if the box is checked.

Testing Environment

Documentation

Notes for Reviewers

I could of made the same exact functions that the instance auto name uses and changed to deployment group but I felt it would be unnecessary code.