search

payara / Payara

Payara Server is an open source middleware platform that supports reliable and secure deployments of Java EE (Jakarta EE) and MicroProfile applications in any environment: on premise, in the cloud or hybrid.
http://www.payara.fish
Other
880 stars 302 forks source link

FISH-8880 Upgrade Exousia to 3.0.0-M3 #6882

Closed kalinchan closed 3 weeks ago

kalinchan commented 1 month ago

Description

Changed from the SimplePolicyProvider to the default

Uses the exousia authorization service

Important Info

Blockers

Testing

New tests

Testing Performed

Testing Environment

Documentation

Notes for Reviewers

OndroMih commented 4 weeks ago

Hi @kalinchan, how are you? I left a few comments where I think this PR violates license or copyright. I hope it's easy to fix.

kalinchan commented 3 weeks ago

Hi @OndroMih,

I have made the changes, let me know if you believe more are required.

OndroMih commented 3 weeks ago

Hi, @kalinchan,

Even though you added the correct copyright, both files are still distributed under both CDDL and GPL licenses. Even if you choose to use the Eclipse Foundation code under the GPL, you cannot redistribute it under a different license. So the whole file should be now only distributed under the GPL license, without CDDL.

Pandrex247 commented 3 weeks ago

// Payara Foundation and/or its affiliates elects to include this software in this distribution under the GPL Version 2 license With this addition it is only distributed under GPL. 

 * If you wish your version of this file to be governed by only the CDDL or
 * only the GPL Version 2, indicate your decision by adding "[Contributor]
 * elects to include this software in this distribution under the [CDDL or GPL
 * Version 2] license."  If you don't indicate a single choice of license, a
 * recipient has the option to distribute your version of this file under
 * either the CDDL, the GPL Version 2 or to extend the choice of license to
 * its licensees as provided above.  However, if you add GPL Version 2 code
 * and therefore, elected the GPL Version 2 license, then the option applies
 * only if the new code is made subject to such option by the copyright
 * holder.
OndroMih commented 3 weeks ago

You're right, @Pandrex247 , I missed that. Then it seems OK.