search

payara / ecosystem-support

Placeholder repository to handle community requests for the Payara Platform ecosystem tools
3 stars 2 forks source link

Enhancement: AmazonSQS connector should support DefaultAWSCredentialsProviderChain #44

Closed nsn closed 1 year ago

nsn commented 2 years ago

Description

AmazonSQSActivationSpec should support DefaultAWSCredentialsProviderChain, either by providing a dedicated @ActionvationConfigProperty or just by default:

return new DefaultAWSCredentialsProviderChain().getCredentials();

Expected Outcome

The default credentials chain should be accessible for users

Current Outcome

only env vras and hard-coded string literals are supported, which makes it difficult to manage credentials securely

Context

All AWS SDKs support chaining of credential providers, by default checking for env vars, ~/.aws files and when deployed in Amazon containers obtaining credentials from the network. Since the AmazonSQS adapter needs to be deployed as a .rar it's impossible to implement not-yet-supported credentials providers, so support for default scheme can only be implemented in the library itself. This would take the burden of managing different secrets for different environments securely from the users.

Ecosystem Tool

Cloud Connectors

smillidge commented 2 years ago

We have a PR for this https://github.com/payara/Cloud-Connectors/pull/379 so plan to provide something based on the PR soon.

JamesHillyard commented 1 year ago

Hi @nsn,

As Steve has said, there is currently a community contribution which we believe will implement the functionality you are requesting. When there is an update regarding this contribution, I will inform you.

Thanks, James

smillidge commented 1 year ago

This was fixed by https://github.com/payara/Cloud-Connectors/pull/539

JamesHillyard commented 1 year ago

Hi @nsn,

As Steve recently said, there has been a PR to fix this. This PR will be included in the Cloud Connectors 0.8.0, which will be released soon. I will again update you when Cloud Connectors 0.8.0 is available.

Thanks, James

JamesHillyard commented 1 year ago

Hi @nsn,

Cloud Connectors 0.8.0 has now been released and contains your suggested enhancement implemented in the PR mentioned by Steve, https://github.com/payara/Cloud-Connectors/pull/539.

Thanks, James