payara / ecosystem-support

Placeholder repository to handle community requests for the Payara Platform ecosystem tools

3 stars 2 forks source link

Enhancement: Support startClass for Payara Micro in Gradle Plugin / FISH-6463 #52

Open drame1499 opened 1 year ago

drame1499 commented 1 year ago

Description

In the maven plugin it is possible to define a start class that is called to bootstrap payara micro. The gradle plugin does currently not support this option.

Expected Outcome

Extend the gradle plugin to include the startClass attribute on the bundle task and generate an included jar and also update the MANIFEST.MF in generated uberJar just like the maven plugin does it

Current Outcome

Attribute startClass is not supported

Context

Ecosystem Tool

id "fish.payara.micro-gradle-plugin" version "1.1.0"

JamesHillyard commented 1 year ago

Hi @drame1499,

Just to clarify, could you please share the maven equivalent you are referring to which is missing in the gradle plugin?

Thanks, James

drame1499 commented 1 year ago

Hi @JamesHillyard

I refer to the https://github.com/payara/ecosystem-maven/tree/master/payara-micro-maven-plugin and the

startClass (optional): Replaces Start-Class definition that resides in MANIFEST.MF file with the provided class.

option. Best regards, Philipp

JamesHillyard commented 1 year ago

Hi @drame1499,

Thank you for clarifying that. I have raised this issue with the internal ID FISH-6463 to implement your enhancement request. We always encourage you to contribute, so if you wish you can submit a PR with implementing this feature, and we will gladly review it. Otherwise, we will pick up the issue at some point in the future.

Thanks, James