Fix channel queue - Githubissues

payjoin / nolooking

Batched Channels from a PayJoin ⚡️🔀

41 stars 8 forks source link

Fix channel queue #68

Closed nickfarrow closed 1 year ago

nickfarrow commented 1 year ago

We somehow missed these in a8ca6eb7f63bd5d5332316b616e8310ae72b7032

Move labels outside channels grid. Get length of children, not NaN. Count nodes using labels correctly dividing by 2.

DanGould commented 1 year ago

Are you leaving fixup commits to be squashed? I'm confused why they're not --autosquash-ed before you push but maybe I'm unfamiliar with this git workflow?

DanGould commented 1 year ago

This structure makes so much more sense

nickfarrow commented 1 year ago

I find it easier to track changes than comparing forcepushes (maintains linear and modular history), Squash and Merge should get rid of them