search

payjoin / rust-payjoin

Supercharged payment batching to save you fees and preserve your privacy
https://payjoindevkit.org
82 stars 34 forks source link

Prepare Payjoin PSBT with no output keypaths #270

Closed DanGould closed 1 month ago

DanGould commented 1 month ago

The BIP78 sender checklist "Verif[ies] that no keypaths is in the PSBT output," and this check was failing with our receiver.

This change ensures that check is satisfied.

https://github.com/bitcoin/bips/blob/master/bip-0078.mediawiki#user-content-Senders_payjoin_proposal_checklist

spacebear21 commented 1 month ago

This seems like something that should be checked in the integration tests.

DanGould commented 1 month ago

Good point. I made bitcoind add bip32derivs (keypaths) in integration tests to check that they're properly cleared. If you cherry-pick 69e2fa1 onto master you can see that it fails without the change.