search

payjoin / rust-payjoin

Supercharged payment batching to save you fees and preserve your privacy
https://payjoindevkit.org
82 stars 34 forks source link

V2 requests are mistakenly being interpreted as v1 requests in params #311

Open spacebear21 opened 1 week ago

spacebear21 commented 1 week ago

Follow-up from https://github.com/payjoin/rust-payjoin/pull/277#pullrequestreview-2139827469

V2 requests are being sent with v=1 default send parameter and thus defaulting to disable_output_substitution = false. v1 requests over v2 directories are in the unsecured payment server category of BIP 78, so any v1 request has output substitution disabled. V2 requests are mistakenly being interpreted as v1 requests wrt Params.