type: row admin condition seems broken

[dacgray]

Link to reproduction

No response

Describe the Bug

                {
                    label: 'Items',
                    name: 'items',
                    type: 'array',
                    labels: {
                        singular: 'Item',
                        plural: 'Items',
                    },
                    admin: itemAdmin,
                    fields: [
                        {
                            label: 'Type',
                            name: 'type',
                            type: 'radio',
                            required: true,
                            options: [location, socialMedia, trustpilot],
                        },
                        {
                            label: 'Location',
                            type: 'group',
                            name: location.value,
                            admin: {
                                condition: (data, siblingData) =>
                                    siblingData.type === location.value,
                            },
                            fields: [
                                {
                                    label: 'Type',
                                    name: 'type',
                                    type: 'radio',
                                    required: true,
                                    options: [Fields.staticPage, Fields.link],
                                },
                                {
                                    admin: {
                                        condition: (data, siblingData) => {
                                            console.log('a', siblingData)
                                            return (
                                                siblingData.type ===
                                                Fields.staticPage.value
                                            )
                                        },
                                    },
                                    type: 'row',
                                    fields: [
                                        {
                                            label: 'Page Tag Filter',
                                            name: 'pageSelector',
                                            type: 'relationship',
                                            relationTo: 'page-tag-v1',
                                            admin: {
                                                width: '50%',
                                            },
                                        },
                                        {
                                            label: 'Target Url',
                                            name: 'staticPage',
                                            type: 'relationship',
                                            required: true,
                                            relationTo: 'static-page-v1',
                                            filterOptions: ({
                                                siblingData,
                                            }) => ({
                                                tags: {
                                                    equals: siblingData[
                                                        'pageSelector'
                                                    ],
                                                },
                                            }),
                                            admin: {
                                                width: '50%',
                                            },
                                        },
                                    ],
                                },

                                {
                                    admin: {
                                        condition: (data, siblingData) => {
                                            console.log('b', siblingData)
                                            return (
                                                siblingData.type ===
                                                Fields.link.value
                                            )
                                        },
                                    },
                                    label: 'External Link',
                                    name: 'link',
                                    type: 'relationship',
                                    required: true,
                                    relationTo: 'link-v1',
                                },
                            ],
                        },
                    ],
                },

If I place the condition on the row field sibling data is mixed between the item array object and the location group object:

If I place the condition on pageSelector and staticPage things work as expected:

{
                    label: 'Items',
                    name: 'items',
                    type: 'array',
                    labels: {
                        singular: 'Item',
                        plural: 'Items',
                    },
                    admin: itemAdmin,
                    fields: [
                        {
                            label: 'Type',
                            name: 'type',
                            type: 'radio',
                            required: true,
                            options: [location, socialMedia, trustpilot],
                        },
                        {
                            label: 'Location',
                            type: 'group',
                            name: location.value,
                            admin: {
                                condition: (data, siblingData) =>
                                    siblingData.type === location.value,
                            },
                            fields: [
                                {
                                    label: 'Type',
                                    name: 'type',
                                    type: 'radio',
                                    required: true,
                                    options: [Fields.staticPage, Fields.link],
                                },
                                {
                                    type: 'row',
                                    fields: [
                                        {
                                            label: 'Page Tag Filter',
                                            name: 'pageSelector',
                                            type: 'relationship',
                                            relationTo: 'page-tag-v1',
                                            admin: {
                                                condition: (
                                                    data,
                                                    siblingData
                                                ) => {
                                                    console.log(
                                                        'a',
                                                        siblingData
                                                    )
                                                    return (
                                                        siblingData.type ===
                                                        Fields.staticPage.value
                                                    )
                                                },
                                                width: '50%',
                                            },
                                        },
                                        {
                                            label: 'Target Url',
                                            name: 'staticPage',
                                            type: 'relationship',
                                            required: true,
                                            relationTo: 'static-page-v1',
                                            filterOptions: ({
                                                siblingData,
                                            }) => ({
                                                tags: {
                                                    equals: siblingData[
                                                        'pageSelector'
                                                    ],
                                                },
                                            }),
                                            admin: {
                                                condition: (
                                                    data,
                                                    siblingData
                                                ) => {
                                                    console.log(
                                                        'a',
                                                        siblingData
                                                    )
                                                    return (
                                                        siblingData.type ===
                                                        Fields.staticPage.value
                                                    )
                                                },
                                                width: '50%',
                                            },
                                        },
                                    ],
                                },

                                {
                                    admin: {
                                        condition: (data, siblingData) => {
                                            console.log('b', siblingData)
                                            return (
                                                siblingData.type ===
                                                Fields.link.value
                                            )
                                        },
                                    },
                                    label: 'External Link',
                                    name: 'link',
                                    type: 'relationship',
                                    required: true,
                                    relationTo: 'link-v1',
                                },
                            ],
                        },
                    ],
                },

To Reproduce

Above

Payload Version

2.11.2

Adapters and Plugins

"@payloadcms/bundler-webpack": "^1.0.6", "@payloadcms/db-mongodb": "^1.3.2", "@payloadcms/plugin-cloud-storage": "^1.1.1", "@payloadcms/plugin-sentry": "^0.0.6", "@payloadcms/richtext-slate": "^1.3.1",

[SimYunSup]

I think you have to define row's name if you want to use condition in row.

https://github.com/payloadcms/payload/blob/1c0d43c61a0e29bc9de50a4e608cb7dff9d5cd48/packages/payload/src/admin/components/forms/withCondition/WatchCondition.tsx#L44-L65

condition property needs path internally, but path is blank string if name is not exists.

https://github.com/payloadcms/payload/blob/1c0d43c61a0e29bc9de50a4e608cb7dff9d5cd48/packages/payload/src/admin/components/forms/RenderFields/index.tsx#L111

[dacgray]

Adding name to the row field causes a type error and kills the build:

[SimYunSup]

Oh, very sorry. I was mistaken. RowField is present-only, so name field is not exists in type. So that was bug.

It causes because of row's path is parent's path, so getSiblingData returns parent's siblingData.

getSiblingData code should add edge case for present-only fields, but I can't think how it changes to.

I'm sorry that I was mistaken.