fix: graphql query concurrency issues

payloadcms / payload

Payload is the open-source, fullstack Next.js framework, giving you instant backend superpowers. Get a full TypeScript backend and admin panel instantly. Use Payload as a headless CMS or for building powerful applications.

https://payloadcms.com

MIT License

23.54k stars 1.5k forks source link

fix: graphql query concurrency issues #6925

Closed PatrikKozak closed 2 months ago

PatrikKozak commented 3 months ago

Description

This is the beta (v3) PR for the v2 PR here

Addresses #6800, #5108

[x] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have added tests that prove my fix is effective or that my feature works
[x] Existing test suite passes locally with my changes

yobottehg commented 2 months ago

Any chance to get this in? We currently have inconsistent GraphQL responses which makes development a bit tedious.

yobottehg commented 2 months ago

I just wanted to add that these changes here in the PR applied against beta.58 via patch-package solve both problems we currently have with payload graphql:

concurrent requests can fail
some requested relations will randomly be empty on requests. See also the Discord discussion regarding this: https://discord.com/channels/967097582721572934/1209342986610024468