`db-mongodb`: id parsing issues

Fitch24 commented 1 month ago

Link to reproduction

https://github.com/Fitch24/payload/blob/mongodb-id-parsing-issue/test/_community/int.spec.ts

Describe the Bug

db-mongodb adapter produces some bugs when passing non-standard id (non ObjectId values or ObjectId with uppercase symbols) in local/rest (and probably GraphQL) API

Server returns 500 InternalServerError if it's failed to parse (cast to ObjectId) id in REST-API queries. I think, it must be a client error, because of passing correct id type is part of validation and not a server problem.
When filling any relationship fields with id that contains upper case symbols, field population will be broken. Also admin UI in collection list view will be infinitely trying to populate broken field without success (I have no reproduction for this)

To Reproduce

Use collection with relationship field
Add item to collection with relationship field in uppercase (via REST-API for example, because of you can't pass raw id directly in Admin-UI)
Try to query this collection and see that relationship field is not populated

Please see reproduction link for more detailed example

Payload Version

2.30.1

Adapters and Plugins

db-mongodb

DanRibbens commented 1 month ago

~This PR should address your issue: https://github.com/payloadcms/payload/pull/8395/files~

My mistake, that PR is for v3.

It seems we'll have to do some sanitization of relationship IDs to insert them in lowercase format.

github-actions[bot] commented 1 month ago

🚀 This is included in version v3.0.0-beta.114

github-actions[bot] commented 3 weeks ago

This issue has been automatically locked. Please open a new issue if this issue persists with any additional detail.

payloadcms / payload