Join field 'create new' causing 303's and mass redirects resulting in multiple drafts being generated

payloadcms / payload

Payload is the open-source, fullstack Next.js framework, giving you instant backend superpowers. Get a full TypeScript backend and admin panel instantly. Use Payload as a headless CMS or for building powerful applications.

MIT License

25.65k stars 1.63k forks source link

Describe the Bug

Clicking the Create new on a join field table button causes drawer to open as expected with the loading overlay, however it also causes multiple POST requests to the collection and the creation of (in my testing) 3 drafts unintentionally.

See the issue in action: https://github.com/user-attachments/assets/f3f6845f-bad0-4dc4-ae26-7edb8dd31a7b

Link to the code that reproduces this issue

https://github.com/akhrarovsaid/payload-beta.132-join-drafts-issue-on-create-new

Reproduction Steps

Create a new website template with Postgres adapter
Create the first user as usual
Seed the database

Add the following field to Categories:

{
type: 'join',
on: 'categories',
collection: 'posts',
name: 'relatedPosts'
}

pnpm dev
Navigate to categories
Select a category
Click create new on join table
Observe unexpected behavior and server stdout.

Which area(s) are affected? (Select all that apply)

db-postgres, area: templates, area: core

Environment Info

Binaries:
  Node: 20.10.0
  npm: N/A
  Yarn: N/A
  pnpm: 9.11.0
Relevant Packages:
  payload: 3.0.0-beta.132
  next: 15.0.0
  @payloadcms/live-preview: 3.0.0-beta.132
  @payloadcms/richtext-lexical: 3.0.0-beta.132
  @payloadcms/translations: 3.0.0-beta.132
  react: 19.0.0-rc-65a56d0e-20241020
  react-dom: 19.0.0-rc-65a56d0e-20241020
Operating System:
  Platform: win32
  Arch: x64
  Version: Windows 10 Home
  Available memory (MB): 16268
  Available CPU cores: 4

Please add a reproduction in order for us to be able to investigate.

Depending on the quality of reproduction steps, this issue may be closed if no reproduction is provided.

Why was this issue marked with the `invalid-reproduction` label?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We prefer a link to a public GitHub repository created with create-payload-app@beta -t blank or a forked/branched version of this repository with tests added (more info in the reproduction-guide).

To make sure the issue is resolved as quickly as possible, please make sure that the reproduction is as minimal as possible. This means that you should remove unnecessary code, files, and dependencies that do not contribute to the issue. Ensure your reproduction does not depend on secrets, 3rd party registries, private dependencies, or any other data that cannot be made public. Avoid a reproduction including a whole monorepo (unless relevant to the issue). The easier it is to reproduce the issue, the quicker we can help.

Please test your reproduction against the latest version of Payload to make sure your issue has not already been fixed.

I added a link, why was it still marked?

Ensure the link is pointing to a codebase that is accessible (e.g. not a private repository). "example.com", "n/a", "will add later", etc. are not acceptable links -- we need to see a public codebase. See the above section for accepted links.

payloadcms / payload