search

paylogic / pip-accel

pip-accel: Accelerator for pip, the Python package manager
https://pypi.python.org/pypi/pip-accel
MIT License
308 stars 35 forks source link

.travis.yml: Use new container infrastructure #46

Closed msabramo closed 9 years ago

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-4.36%) when pulling 71b1000182645acf73e518f05e30195140111922 on msabramo:patch-1 into f315eecf87b60028b5707c6f18af353c8d0421ce on paylogic:master.

xolox commented 9 years ago

Hi Marc,

Thanks for the pull request! A bit more context would have been nice, on the other hand I can search just fine. If anyone else is interested, see the blog post Faster Builds with Container-Based Infrastructure and Docker on the Travis CI blog.

There is however a reason why I'm not ready to switch the pip-accel test suite to use Travis CI's container-based infrastructure at the moment: pip-accel contains support for system package dependency handling and the test suite verifies that this works (this is why your pull request decreased the test suite coverage by about 5%). This requires sudo and this is why the build output of your pull request mentions sudo: must be setuid root.

I really do want this test to run, so for now I will wait to see if the Travis CI team is willing to add sudo support to their Docker containers.

Update: I know why sudo inside Docker containers isn't supported right now, the blog post linked above explains in more detail. I'm not sure if/when the Travis CI team will enable usage of sudo (or provide a suitable workaround).

xolox commented 9 years ago

As I explained before, running the full pip-accel test suite requires super-user access. I kept this pull request open in the hope that Travis CI would enable sudo in Docker containers soon, but it doesn't look like that is going to happen.

I'm going to close this pull request now because I don't want to give up coverage for faster builds (I don't mind builds being a bit slow) and I don't like keeping this pull request open for months without a reason to assume Travis CI is going to change their policy anytime soon.

msabramo commented 9 years ago

That makes sense. I agree that coverage trumps faster builds.