search

paylogic / pip-accel

pip-accel: Accelerator for pip, the Python package manager
https://pypi.python.org/pypi/pip-accel
MIT License
308 stars 35 forks source link

Integrate Windows support from #60 #61

Closed xolox closed 8 years ago

xolox commented 8 years ago

This pull request summarizes the changes that @matysek, @theyoprst and I have made in order to add support for the Windows platform to pip-accel.

I merged the changes from pull request #60 into the windows-support feature branch in order to restore Python 2.6 compatibility, fix some broken tests and finish the remaining TODO remarks (namely cache invalidation through atomic file replacement).

In the process of working on this feature branch I've set up automated continuous integration on Windows using AppVeyor so I'm also including the resulting appveyor.yml configuration file (to make testing forks easier).

xolox commented 8 years ago

Preliminary conclusion about integration between GitHub, AppVeyor and Coveralls: It kind of works but it's not exactly ideal. Some things I noticed:

  1. The status checks in this pull request state that the AppVeyor build failed. It did indeed fail, but after successfully running the test suite! The coveralls program fails with "You have to provide either repo_token in .coveralls.yml, or launch via Travis or CircleCI". However there's a second build for the same commit and that one succeeded. So apparently builds triggered by pull requests can't submit coverage and therefor fail :-s.
  2. When coverage statistics are successfully submitted to Coveralls the pathnames contain backslashes. Possibly due to point one I haven't seen combined statistics but I'm guessing they would list separate files (the only differences being slashes versus backslashes :-).
  3. It's weird that a commit in a feature branch pushes coverage statistics under the label HEAD without any further branch information.

Oh well, it was an interesting experiment :-).