search

paymill / paymill-java

Java wrapper for Paymill API
http://paymill.github.io
MIT License
26 stars 22 forks source link

Isolate Jersey dependency #51

Closed basoko closed 10 years ago

basoko commented 10 years ago

I have done a small refactor with the aim of isolate the Jersey dependency.

nikoloff commented 10 years ago

I like this proposal. I will touch the methods visibility and will build a new version with it.

thx

basoko commented 10 years ago

Ok @nikoloff but if you want I can change the methods visibility that you think need a change and update the pull request.

Regards.

nikoloff commented 10 years ago

Yes thx @basoko , that will be great. In the services package the utilities classes ParameterMap and HttpClient with it's methods should be final with package visibility.

basoko commented 10 years ago

Sorry @nikoloff, I'm not sure about what you mean because ParameterMap is final and HttpClient is an interface so it can not be final. I can't change the package visibility because the HttpClient interface is needed in the PaymillContext class, so it has to have public visibility, and at the same time it depends on ParameterMap, so this last one should also be public.

stoilkov commented 10 years ago

@basoko sorry about the merge delay, we will take care of both pull requests next week. Again, thanks for the contribution.

basoko commented 10 years ago

Hi @nikoloff, @stoilkov is this PR alive?

stoilkov commented 10 years ago

@basoko sorry about the delay. will take care of this today.

basoko commented 10 years ago

@stoilkov Don't worry, there's no rush. I only wanted to know if there's something I can do to improve it.