paynl / magento-plugin

Pay.nl magento plugin
9 stars 12 forks source link

Fix indices of AppliedTaxes array of Quote Address Model #36

Closed iamniels closed 3 years ago

iamniels commented 5 years ago

The indices of the AppliedTaxes array of the Mage_Sales_Model_Quote_Address objects need to be the VAT id's.

In the Pay_Pa...al_Paymentcharge::collect the indices are numbered. This causes that if (isset($ratesIdQuoteItemId[$id])) in function Mage_Tax_Model_Observer::salesEventOrderAfterSave fails and then the Sales_Order_Tax_Item models are not created. This causes various problems throughout the system. We noticed that the VAT summary created by Fooman PDCustomiser was not complete.

Using the Github web editor introduced a newline at the end of the file.