Checkout page - layout issue

paynl / magento2-plugin

The Pay. plugin for Magento 2

https://www.pay.nl

27 stars 32 forks source link

Checkout page - layout issue #11

Closed bezigeboefjes closed 7 years ago

bezigeboefjes commented 7 years ago

There is a layout issue with the header in the checkout page when the paynl module is enabled. Please check attached screenshots. When the paynl module is disabled, the layout of the checkout page is normal. I've reset the theme to the default Luma, with original CSS stylesheets, to make sure it's not a theme error.

To reproduce:

# magento module:disable Paynl_Payment
=> Normal layout
# magento module:enable Paynl_Payment
=> Wrong header

Wrong header: paynl-enabled

Normal header: paynl-disabled

bezigeboefjes commented 7 years ago

Here's the fix:

In view/frontend/layout/checkout_index_index.xml:

Change:
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" layout="1column" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">

To:
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" layout="checkout" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">

andypieters commented 7 years ago

Merged your pull request