search

paynl / magento2-plugin

The Pay. plugin for Magento 2
https://www.pay.nl
27 stars 31 forks source link

The Apikey used in the finish controller should be dependend on the store where the order has been placed #163

Closed stormbyte closed 2 years ago

stormbyte commented 2 years ago

When a payment has been placed and the transaction is verified the API key used should be fetched with the storeId saved with the order. As magento does not load the store based on the url, the store should be fetched from the order itself.

https://github.com/paynl/magento2-plugin/blob/master/Controller/Checkout/Finish.php#L93

woutse commented 2 years ago

Thanks for your message. We'll look into it!

stormbyte commented 2 years ago

For credit card USA there is also https://github.com/paynl/magento2-plugin/blob/master/Controller/Checkout/Exchange.php#L121

This is also getting the wrong API key

woutse commented 2 years ago

Again, thanks for your message. We will update this within the next release.

woutse commented 2 years ago

He! We fixed this in the release 2.4.0. Closing this issue now!