payola / Payola

RDF framework
http://payola.cz
62 stars 15 forks source link

Design of new ontology customization freezes immediately after setting the namespace #43

Open svatek opened 10 years ago

svatek commented 10 years ago

When designing a new ontology customization, with a graph view opened, after setting the customization name and namespace, the processing freezes, with a progress bar. Tested in FF and Chrome. ontology_customization_bug

jirihelmich commented 10 years ago

Ondra, could you resolve this, please?

kudlondr commented 10 years ago

Sorry for the delay, I must have missed the email notification.

I used http://dbpedia.org/ontology/Settlement and http://dbpedia.org/ontology/City and the customization was successfully created. Is the error still uccurring? If so, could you, please, send me the ontology URI, that you are trying to create customization from?

jirihelmich commented 10 years ago

I think it's PCO: https://code.google.com/p/public-contracts-ontology/

jirihelmich commented 10 years ago

When I see the screenshot, I think I know where the problem is.

The URL is not meant to be a namespace, but actually an URL containing the ontology definition to be downloaded and parsed, like http://opendata.cz/pco/public-contracts.ttl

Am I right, Vojtech?

Ondra, please, check the behaviour for the case an URL with invalid data (e.g. not an ontology,) is passed.

kudlondr commented 10 years ago

When no ontology identifier is set in the "Create a new ontology customization" dialog or any identifier pointing to data describing something other than an ontology, Payola does not freeze, but the input fields the dialog get highlighted.

I guess, it may be some other error. But I'm not able to get Payola frozen. The edit dialog is shown or the load bar disappears.

jirihelmich commented 10 years ago

I think (based on screenshot), that Vojtech filled in "http://purl.org/goodrelations/v1#". So not empty, but this, which does not point to the ontology definition itself.

kudlondr commented 10 years ago

Well, http://purl.org/goodrelations/v1# works fine and creates a customization, but it is now forwarded to http://www.heppnetz.de/ontologies/goodrelations/v1.owl. Which might not have been back then, when Mr Svatek created this issue.

jirihelmich commented 10 years ago

I just tried to reproduce by filling in "http://www.heppnetz.de/ontologies/goodrelations/v1#" and it did not freeze, you're right.

kudlondr commented 10 years ago

I guess, this is resolved

jirihelmich commented 10 years ago

I just tried on Vojtech's notebook and under his account, it is definitely an issue.

kudlondr commented 10 years ago

Jirka, could you, please, send me the ontology URI, that you were trying to create?

jirihelmich commented 10 years ago

It is still the http://www.heppnetz.de/ontologies/goodrelations/v1.owl.

The problem is that it works under admin@payola account and not under Vojtech's newly created one. Any ideas? I can help you to solve this, but it would be great to have a basic idea about what's wrong...

kudlondr commented 10 years ago

Well I found an error, coasing that buttons Create User and Ontology customizations were not visible for users without any owned customizations. After fixing that, creating an ontology customization was no problem at all and the editation dialog poped right up.

That might solve the issue you found. After the ontology customization is created, the dropdown menu with customizations is updated. At that point, JavaScript might have gotten stuck, as Vojtech described. I will upload the fix right up to playground.

I might use some help with css on the edit customization dialogs, which are still mess after the bootstrap migration. If you are interested, pick Ontology or (if you got more spare time) User customization editor dialog.

jirihelmich commented 10 years ago

OK, I don't have Vojtech's credentials, so I cannot confirm it is fixed. Maybe he will.