search

paypal / Illuminator

iOS Automator
Apache License 2.0
38 stars 27 forks source link

xcode 6.3.1 build error when building for device #52

Closed tmeisenh closed 9 years ago

tmeisenh commented 9 years ago

When building for the device with Xcode 6.3.1, Build version 6D1002, the build errors out due to xcodebuild: error: -destination implies architecture, -arch must not also be specified. I just commented out the arch and it built fine. Did not test with older xcodes since I already saw 5 was marked for deprecation and that was the only other xcode I had.

tmeisenh commented 9 years ago

Does xcodebuild change its arguments very often? If it does then it might make sense to introduce a strategy pattern to encapsulate the options a particular version wants. If that was done then I think it would be easier to support new and older versions of xcodebuild (support two most recent versions? idk).

I'm not sure how this would look in the code but I can probably get something for review in a few days. On the flipside if xcodebuild does not change its arguments very oftne then I don't know how much value pulling out strategies would be.

ianfixes commented 9 years ago

Doing a strategy pattern might make sense, but I don't think these arguments change that often (and if Xcode breaks compatibility, Illuminator will be following suit, by necessity). One thing that's clear to me is that since this project is new enough, I don't know all the use cases that people need for build options.

My best-case scenario would be to have Illuminator stay away from wrapping any & all Xcode errors -- just make AutomationBuilder be more careful about how it auto-fills the compiler options.

ianfixes commented 9 years ago

OK, I'm officially back from vacation travel. I can see now that my initial comment was stupid, and that @kviksilver had it right -- we need to remove the line that was commented, and that's all.

Just fix that and I'll merge. Sorry for the delay.