paypal / Illuminator

iOS Automator
Apache License 2.0
38 stars 27 forks source link

Warnings generated in PPAutomationBridge.m #88

Closed rgonzo closed 7 years ago

rgonzo commented 9 years ago

Here are the errors:

PPAutomationBridge.m:132:13: multiple methods named 'objectForKey:' found [-Wstrict-selector-match]

    if ([jsonObject objectForKey:@"callUID"]) {
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

PPAutomationBridge.m:133:35: multiple methods named 'objectForKey:' found [-Wstrict-selector-match]

        [returnDict setObject:[jsonObject objectForKey:@"callUID"] forKey:@"callUID"];

^~~~~~~~~~~

PPAutomationBridge.m:287:77: implicit conversion changes signedness: 'NSInteger' (aka 'int') to 'NSUInteger' (aka 'unsigned int') [-Wsign-conversion]

                [self.inputData appendBytes:(const void *)buffer length:len];

^~~~~~~~~~~

PPAutomationBridge.m:294:98: implicit conversion changes signedness: 'NSInteger' (aka 'int') to 'NSUInteger' (aka 'unsigned int') [-Wsign-conversion]

                NSString* json = [[NSString alloc] initWithBytes:self.inputData.bytes length:jsonMessageLength encoding:NSASCIIStringEncoding];
                ~                                                       ^~~

PPAutomationBridge.m:295:72: implicit conversion changes signedness: 'NSInteger' (aka 'int') to 'NSUInteger' (aka 'unsigned int') [-Wsign-conversion]

                [self.inputData replaceBytesInRange:NSMakeRange(0, jsonMessageLength) withBytes:nil length:0];
                                 ~                                                           ^~~~~~~~~~~~~~~~~

PPAutomationBridge.m:321:73: implicit conversion changes signedness: 'NSInteger' (aka 'int') to 'NSUInteger' (aka 'unsigned int') [-Wsign-conversion]

                [self.outputData replaceBytesInRange:NSMakeRange(0, r) withBytes:nil length:0];
                                                    ~~~~~~~~~~~    ^~~~~~~~~~~~~~~~~

PPAutomationBridge.m:352:28: implicit conversion changes signedness: 'NSUInteger' (aka 'unsigned int') to 'long' [-Wsign-conversion]

for (long i = 0, len = data.length; i < len; i++) {
                                                     ~~~~~~~~~~~    ^

PPAutomationBridge.m:353:18: implicit conversion changes signedness: 'const uint8_t' (aka 'const unsigned char') to 'char' [-Wsign-conversion]

    char c = bytes[i];
                 ~~~   ^~~~~~~~~~~

PPAutomationBridge.m:381:34: implicit conversion changes signedness: 'NSUInteger' (aka 'unsigned int') to 'long' [-Wsign-conversion]

for (long i = start+1, len = self.inputData.length; i < len; i++) {
         ~   ^~~~~~~~

PPAutomationBridge.m:382:18: implicit conversion changes signedness: 'const uint8_t' (aka 'const unsigned char') to 'char' [-Wsign-conversion]

    char c = bytes[i];
                       ~~~   ^~~~~~~~~~~~~~~~~~~~~

I have suppressed them with the following pragma statements:

pragma GCC diagnostic ignored "-Wstrict-selector-match"

pragma GCC diagnostic ignored "-Wsign-conversion"

ianfixes commented 7 years ago

Closing due to lack of activity, in preparation for our V2 release (#99) which rewrites the bridge in Swift.