paypal / NNAnalytics

NameNodeAnalytics is a self-help utility for scouting and maintaining the namespace of an HDFS instance.
Apache License 2.0
110 stars 71 forks source link

[#310] CachedQuotas.analyze creates unnecessary HashSets #313

Closed pjeli closed 2 years ago

pjeli commented 2 years ago

Make sure you have checked all steps below.

GitHub Issue

Fixes #310

Checklist:

What is the purpose of this pull request?

How was this change validated?

Commit Guidelines

codecov[bot] commented 2 years ago

Codecov Report

Merging #313 (b8c99e9) into master (ea294f9) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #313      +/-   ##
============================================
+ Coverage     74.31%   74.34%   +0.02%     
- Complexity     1075     1076       +1     
============================================
  Files            56       56              
  Lines          7083     7082       -1     
  Branches        638      638              
============================================
+ Hits           5264     5265       +1     
+ Misses         1423     1422       -1     
+ Partials        396      395       -1     
Impacted Files Coverage Δ
...adoop/hdfs/server/namenode/cache/CachedQuotas.java 86.13% <100.00%> (-0.14%) :arrow_down:
...menode/analytics/web/NamenodeAnalyticsMethods.java 68.87% <0.00%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea294f9...b8c99e9. Read the comment docs.