search

paypal / PayPal-node-SDK

node.js SDK for PayPal RESTful APIs
Other
1.28k stars 451 forks source link

Add /Billing/Subscription - Paypal API deprecated Billing Agreements #418

Open givethemheller opened 5 years ago

givethemheller commented 5 years ago

Paypal has deprecated the Billing Agreements and Billing Plans API endpoints. Need to do something about that here too, but at the moment, this is only about getting the new beta release up to speed with the current release of the paypal api.

This PR adds the routes corresponding to documentation at paypal in the below link. I also did it somewhat haphazardly. Done so very intentionally to make sure the contributors here were aware of the changes and could take a better look at this.

I now have to go back to trying not to starve. I'll be continually updating this fork of mine as I work through issues I (expect to) find.

Please feel free to pull cherry pick my commit and do what ever you want with it. I wish I had more time to do a thorough job with this, but I just don't have the time. Figured I could write my own promises or try and help out over here.

TODO

Gr8z commented 4 years ago

Why is this PR not merged yet

givethemheller commented 4 years ago

@Gr8z seeing a failure and not sure why - will pull it down and see whats happening. I got started at using this package and then it fell off the feature train for a while.

manuargue commented 4 years ago

@lukeatt @givethemheller is there anything I can do to help merging this pr? Changes look good and the CI failed for unrelated reasons to this pr