Implements #356 (a) Added support for negative pageValidators

paypal / SeLion

Enabling Test Automation in Java

http://selion.io

Apache License 2.0

281 stars 233 forks source link

Implements #356 (a) Added support for negative pageValidators #358

Closed ibugaienko closed 7 years ago

ibugaienko commented 7 years ago

[X] By placing an X in the preceding checkbox, I verify that I am a PayPal employee or I have signed the Contributor License Agreement

This pull request addresses problem discussed in #356 (1st solution)

mach6 commented 7 years ago

@ibugaienko all in all I like this.. Just had the couple small points of feedback

ibugaienko commented 7 years ago

@mach6 , thank you, great feedback! As the code written here, any of these will work, which is why I decided to include them all (even most odd ones) in the test. I will update the code checking action to be more picky.

mach6 commented 7 years ago

@ibugaienko any update on this?

ibugaienko commented 7 years ago

@mach6 , sorry to keep you waiting, I have updated the code, currently only below syntax is supported: hiddenButton.isNotVisible "!hiddenButton.isVisible" "!continueButton"

Please let me know what you think.