search

paypal / bootstrap-accessibility-plugin

Accessibility Plugin for Bootstrap 3 and Bootstrap 3 as SubModule
http://paypal.github.io/bootstrap-accessibility-plugin/demo.html
BSD 3-Clause "New" or "Revised" License
789 stars 189 forks source link

Keyboard Accessibiliy fixes for Tab #109

Closed pp-surbhigupta closed 7 years ago

pp-surbhigupta commented 7 years ago
  1. Tabpanel should be activated on using spacebar
  2. The tabpanel div should not have tabindex: 0 as its non interactive. The plugin added tabindex: 0 which caused the tabpanel div to receive focus. Only interactive elements inside the tabpanel should receive focus

Reference: https://www.w3.org/TR/wai-aria-practices/#tabpanel In the example provided here too, active tab's tabpanel div does not have tabindex: 0

Tested on Firefox, Chrome and IE-11

weboverhauls commented 7 years ago

I disagree with proposal.

  1. Spacebar only needed "if it was not activated automatically on focus."
  2. tabindex:0 may be needed for visual keyboard-only users to read all of panel content; see this example: https://weboverhauls.github.io/demos/tab-panel/