search

paypal / bootstrap-accessibility-plugin

Accessibility Plugin for Bootstrap 3 and Bootstrap 3 as SubModule
http://paypal.github.io/bootstrap-accessibility-plugin/demo.html
BSD 3-Clause "New" or "Revised" License
790 stars 189 forks source link

Use data-target attribute if present (Collapse extension) #30

Closed janwalther closed 10 years ago

janwalther commented 10 years ago

This patch fixes a JS error when the element with the attribute data-toggle="collapse" has a URL href (instead of a jQuery selector) and additionally a data-target attribute with the jQuery selector for the collapsible element. This is useful if you want to offer the opportunity to open the link in a new window (or even when JS is disabled). Example: <a data-toggle="collapse" href="http://www.example.org/" data-target="#collapsibleElement> Collapsible Group Item #1

mpnkhan commented 10 years ago

Hi @rwdaryl . Thanks for your time and effort.

janwalther commented 10 years ago

Could you please update the minified js file?

mpnkhan commented 10 years ago

Yes Done. Sorry i forgot to.

janwalther commented 10 years ago

Github still says
bootstrap-accessibility.js 9 days ago bootstrap-accessibility.min.js 24 days ago

Does it need some time till the files get updated?

mpnkhan commented 10 years ago

Nope github pages are quickest. For me its showing your changes