search

paypal / bootstrap-accessibility-plugin

Accessibility Plugin for Bootstrap 3 and Bootstrap 3 as SubModule
http://paypal.github.io/bootstrap-accessibility-plugin/demo.html
BSD 3-Clause "New" or "Revised" License
790 stars 189 forks source link

Bootstrap accessibility plugin does not check Twitter Bootstrap availability before prototyping its functions #67

Closed franck-grenier closed 9 years ago

franck-grenier commented 9 years ago

Hello, I'm using "bootstrap-accessibility-plugin" on a website on which each page does not include the whole Bootstrap framework.

And this makes the below error happen :

TypeError: $.fn.modal is undefined bootstrap-accessibility.js Line 98

It looks like Bootstrap accessibility plugin does not check if Twitter Bootstrap functions are available before prototyping them. Or maybe I do not include it correctly.

Do you have any idea about that problem ?

weboverhauls commented 9 years ago

Including Bootstrap in full is required.

franck-grenier commented 9 years ago

Ok, I understand the actual requirement but... Don't you think it could be better with these checkings ?

I'm gonna fork your repo and try to implement it.