CLI should never (or very rarely) output the string 'null'

paypal / butterfly

Application transformation tool

https://paypal.github.io/butterfly/

MIT License

47 stars 50 forks source link

CLI should never (or very rarely) output the string 'null' #350

Closed crankydillo closed 4 years ago

crankydillo commented 4 years ago

If the appropriate CLI arguments aren't specified, the upgrade version is displayed as 'null' from this LoC. Some alternatives for dealing with this:

Require the CLI argument
Don't require it, but default it to something (LATEST, UNSPECIFIED, etc.)
Don't require it, but handle it in the code somehow (e.g. just output LATEST, UNSPECIFIED, etc. if null)

I think I like the second option.

Update: Added link

fabiocarvalho777 commented 4 years ago

Sorry, Sam, but ths issue isn't clear. You forgot to add the link. Also, regardless of the link, I am not sure what you are referring to. Could you provide sample steps to reproduce it and sample output? Thanks!!

crankydillo commented 4 years ago

Hey Fabio, this is the problematic output:

Performing upgrade from version 3.10.1 to version null (it might take a few seconds)

I can't give you exact reproducible, but I believe you get it if you just use:

butterfly path-to-project

I added the link above. To be honest, that was the key part that I was hoping would explain things. Sorry I missed it.

fabiocarvalho777 commented 4 years ago

Thanks!! Obviously this isn't required, but if you feel like fixing this that would be very much appreciated. Thanks again.