Butterfly should allow numbers in the extension property names

[fabiocarvalho777]

According to Butterfly CLI help, Butterfly should allow numbers in the extension property names. However, it does not, as seen here.

The first character must be alphabetic only, and the others maybe alphabetic, numeric, dot, underscore or hyphen.

This is a bug, and should be fixed.

[himanshugoyal1065]

Hi @fabiocarvalho777, I'll like to take up this issue. :)

[fabiocarvalho777]

Sure, go for it, please. :-)

[himanshugoyal1065]

Hi @fabiocarvalho777, I tried installing Butterfly via brew but got an error(the repo is archived so can't really open an issue there)

TIA :)

[fabiocarvalho777]

Hello, I have just unarchived the repo. Could you try again and let me know, please? Thanks.

[fabiocarvalho777]

Hey @himanshugoyal1065 ,

To unblock you, until we solve the brew problem, please install Butterfly CLI using the zip file. The instructions are here, under section Installing Butterfly from zip file.

Thanks.

[fabiocarvalho777]

Hello @himanshugoyal1065 . Just checking, are you still working on this issue? Thanks.

[himanshugoyal1065]

Hello @fabiocarvalho777, TBH I'm still not able to install butterfly locally. I might need your help in this. I'll message you personally regarding this, if you don't mind :)

[fabiocarvalho777]

No, problem. You can contact me at fabiocarvalho777@gmail.com. By the way, the best way to develop and test your code changes when adding a new feature or fixing a bug is by running Butterfly from your IDE, as explained in the bottom of this document.

[himanshugoyal1065]

Thank you so much. I'll reach out to you on slack as I work for PayPal only :) Awesome. I'll try running it on my IDE and see how it goes. Thanks again for all your help.

[fabiocarvalho777]

Oh ok, slack sounds good :-)

[huyxgit]

Can I try this one?

[badalsarkar]

Hi Fabio, I looked at this test. Should line 93 be a valid property name as asserted in the test? Reading the comments here and Butterfly CLI Help, it seems to me that it should be invalid.

Please correct me if I am missing something.

[fabiocarvalho777]

Hello Badal,

I looked at this test. Should line 93 be a valid property name as asserted in the test?

You are right, it should not be considered valid. It should be in that array in line 100 but it is not. You caught a bug, thanks! Would you mind fixing it as part of this issue, please? Thanks.

Also, regarding this comment, it doesn't say numbers are also valid, nor that the very first character must be alphabetic. Would you mind changing that comment, please? Here is the rule we want to establish: The first character must be alphabetic only, and the others maybe alphabetic, numeric, dot, underscore or hyphen.

I hope that helps, let me know if you have other questions, and thanks for catching all these details!!

[badalsarkar]

I will do. Thank you. :smile:

[fabiocarvalho777]

@badalsarkar thank you very much for your contribution!! :-)