search

paypal / butterfly

Application transformation tool
https://paypal.github.io/butterfly/
MIT License
47 stars 50 forks source link

Issue#314 Replace Logback with Log4j2 #367

Closed badalsarkar closed 3 years ago

badalsarkar commented 3 years ago

Implements #314 .

Logback is replaced with Log4j2. Log4j2 has been configured to do logging in async manner. I have used system property to dynamically set the log file name here.

I have also configured the loggers to be synchronous for testing purpose.

Please let me know if any change is needed.

Thanks,

fabiocarvalho777 commented 3 years ago

@badalsarkar thank you so much for your contribution. I am on vacation this week, so it might take me a few days to review your PR, but I will add a reminder in my calendar. Thanks again.

By the way, is there any other issue that sounds interesting to you to work with?

badalsarkar commented 3 years ago

@badalsarkar thank you so much for your contribution. I am on vacation this week, so it might take me a few days to review your PR, but I will add a reminder in my calendar. Thanks again.

By the way, is there any other issue that sounds interesting to you to work with?

Thanks Fábio. It was great to be able to contribute. :smiley:

I was actually going through the issues to pick one to work next. There are many that are interesting to me. I will let you know soon.

fabiocarvalho777 commented 3 years ago

@badalsarkar finally reviewed your PR. Added some comments, they are all small. Please address them, or let me know if you have any question. Thanks again for your contribution!

fabiocarvalho777 commented 3 years ago

@badalsarkar answered your comments.

When you provide your next commit, please don't squash it, this way the code review process keeps the history of the changes as we discuss and they get addressed. GitHub will squash everything into a single commit when I merge the PR. Also, please don't mark comments as resolved. That is up to the reviewer to do. This helps to keep track of what is pending what is not. If you want, you can add a comment like "done" once you addressed it. Thanks :-)

badalsarkar commented 3 years ago

@badalsarkar answered your comments.

When you provide your next commit, please don't squash it, this way the code review process keeps the history of the changes as we discuss and they get addressed. GitHub will squash everything into a single commit when I merge the PR. Also, please don't mark comments as resolved. That is up to the reviewer to do. This helps to keep track of what is pending what is not. If you want, you can add a comment like "done" once you addressed it. Thanks :-)

Oh! sorry about that. I am new in open source development. Still learning. I will keep that in mind and also the squashing thing. Thanks. :-)