Get label by full suffix match - Githubissues

paypal / dce-go

Docker Compose Executor to launch pod of docker containers in Apache Mesos.

Apache License 2.0

63 stars 48 forks source link

Get label by full suffix match #102

Closed dpaks closed 3 years ago

dpaks commented 3 years ago

The existing GetLabel() either does a full key match or else matches just the last part of a '.' delimited label.

If label is "a.b.c.d" and key is "a.b.c.d", GetLabel() does a full match.
If label is "a.b.c.d" and key is "c.d", GetLabel() checks only if the last part of the dot delimited label matches i.e., if "d" == "c.d". Providing just "d" as a key can be a risk since "d" maybe a well know name like 'port'.

To circumvent this issue, GetLabelByFullSuffix() can be used.

If label is "a.b.c.d" and key is "a.b.c.d", GetLabelByFullSuffix() does a full match.
If label is "a.b.c.d" and key is "c.d", GetLabelByFullSuffix() checks if "c.d" is the suffix of "a.b.c.d" and if "c.d" is preceeded by a "." in the label.