paypal / dce-go

Docker Compose Executor to launch pod of docker containers in Apache Mesos.
Apache License 2.0
63 stars 48 forks source link

override config by passing mesos labels #53

Closed JiaminZhu closed 6 years ago

JiaminZhu commented 6 years ago

Support config override by passing labels to mesos with prefix "config."

For example, you can add "config.launchtask.timeout" with any value in labels to override default timeout.

asathaye commented 6 years ago

should the dce config be called out specifically? like config.dce. It might be confusing to determine which component this setting/label affects

JiaminZhu commented 6 years ago

You have a valid point. To consider user may use labels to pass some configs to applications, it make sense that we make dce config specifically or even make it configurable to make it more flexible to avoid any conflicts with other labels.