Closed ridv closed 6 years ago
This is great. Thanks for the work! Could you also consider adding a CI status indicator in the README? That would complement this nicely.
@sjlee added a badge to the PR. Thanks for pointing that out!
Thanks @rdelval for the PR! There are internal dependent repos for plugins. So transition from glide to dep would require for those as well. We maintain status quo until we switch to mods or switch to dep for all repos. I see no hard dependency in keeping compatibility with gorealis dependency management.
The hard dependency here was using the same build system to allow it to create the vendor folder correctly. For now I've put a workaround to maintain compatibility but I still think moving to dep is the safer move. Hopefully mods become stable within the next 6 months and we can migrate to them.
The initial build was successful so we're ready to go https://travis-ci.org/paypal/dce-go/builds/448598566
@kkrishna I had to rollback to version v0.13.1 as per https://github.com/Masterminds/glide/issues/1025 in order for this to work. It's ready to go. @JiaminZhu if you have time, look this over and squash and merge when ready 🎉