search

paypal / dce-go

Docker Compose Executor to launch pod of docker containers in Apache Mesos.
Apache License 2.0
63 stars 48 forks source link

Pod should encapsulate variables and use receiver functions #84

Closed ridv closed 2 years ago

ridv commented 4 years ago

https://github.com/paypal/dce-go/blob/develop/utils/pod/pod.go

Has a lot of global variables. This can lead to possible mutations of the variable contents that could create weird behavior.

Ideally, Pod should be an instantiated struct and all the functions which require access to the values inside of pod.