search

paypal / dce-go

Docker Compose Executor to launch pod of docker containers in Apache Mesos.
Apache License 2.0
63 stars 48 forks source link

Refactor stepMetric data and add in healthcheck field #98

Closed chungjin closed 3 years ago

chungjin commented 3 years ago
  1. Refactor the map of interface into a struct 
        {
        "RetryID": 0,
        StepName: "ImagePull",
        "ErrorMsg": "this is the error message",
        "Status": "failed",
        "Tags:" map[string]string{},
        "StartTime": time.Duration in milliseconds
        "EndTime": time.Duration in milliseconds
    },
  2. refactor the SetStepData mathod, seperate into two method, StartStep and EndStep, add corresponding test case
  3. Collect the result of health check into StepData
vipragupta commented 3 years ago

LGTM

chungjin commented 3 years ago

LGTM

Thanks Vipra, I will merge it.