josharian
commented
9 years ago Can you give some idea here about why this code movement and renaming helps with the goal? Something along the lines of:
- Because notifiers depend on foo, which is a linux-specific feature, we move them to blah blah blah. They will be replaced later by nofitiers. This in turn requires making servers into toaster.
- The existing code is already linux-only. Codify that by making it only compile on linux. This also helps clarify what code is platform independent.
- Etc, etc.
Then as I look at the diffs, I can follow along and see your intent, not just the changes.
There might be other significant changes in here beyond the two that I flagged, but I stopped pawing through the commits because I couldn't tell what the goal was, why this is the right approach given that goal, and how the commits accomplished that approach.
This commit pave the way for the coming multi-platform and client support.
It's mostly file rename and re-organization without any significant changes.