search

paypal / gatt

Gatt is a Go package for building Bluetooth Low Energy peripherals
BSD 3-Clause "New" or "Revised" License
1.13k stars 284 forks source link

Add Advertise(a *AdvPacket) to Device interface #48

Closed suapapa closed 9 years ago

suapapa commented 9 years ago

To support advertising custom formatted adv. packet. It will make gatt support other beacons like Eddystone.

Currently only works in Linux.

rabarar commented 9 years ago

Awesome!

On Jul 24, 2015, at 12:57 AM, Homin Lee notifications@github.com wrote:

To support advertising custom formatted adv. packet. It will make gatt support other beacons like Eddystone.

Currently only works in Linux.

You can view, comment on, or merge this pull request online at:

https://github.com/paypal/gatt/pull/48

Commit Summary

Add Advertise(a *AdvPacket) to Device interface File Changes

M device.go (3) M device_darwin.go (5) M device_linux.go (28) Patch Links:

https://github.com/paypal/gatt/pull/48.patch https://github.com/paypal/gatt/pull/48.diff — Reply to this email directly or view it on GitHub.

roylee17 commented 9 years ago

Thanks, @suapapa.

Up to now, there is no way to customize it on OS X.

We had spent much efforts in the design / API / implementation to make sure we can have the stack run on both OS X and Linux. But it is just too much compromises for the Linux folks.

For example, customizing the advertisement is probably one of the first things users want to try it on this package. It actually can be done via the LnxSetAdvertisingData Option, which is, of course, less easy and intuitive than the API proposed.

Since Linux are much more flexible, and people more people uses the package on Linux. I'm thinking to incorporate more Linux only changes, or even start a Linux only branch later.