Feature/adhoc changes - Githubissues

paypal / gatt

Gatt is a Go package for building Bluetooth Low Energy peripherals

BSD 3-Clause "New" or "Revised" License

1.13k stars 284 forks source link

Closed roylee17 closed 9 years ago

roylee17 commented 9 years ago

Revision history: v0: f0aade4d758523dbb0cddf45a1f0a120f01e7f9e

josharian commented 9 years ago

Thanks! Most of this looks good and is much appreciated. (The typ as string stuff was really ugly.) My only real concerns are:

the newly exported constants
uncertainty that I've fully reviewed the changes due to mixing of changes and code movement

roylee17 commented 9 years ago

v1: rework the "att" related changes to address the comments on v0

break down code movement, and changes to separate commit.
abandon changes to the att constant renaming
abandon changes to the type promotion of att (type attOp byte) too many code changes for too few benefit (text string for debugging)

josharian commented 9 years ago

This all looks great. Thanks so much for the fixes and for doing the reorganization; this was dramatically easier to review.