paypal / generator-kraken-react

2 stars 4 forks source link

if this is a "kraken" repo... #1

Open grawk opened 7 years ago

grawk commented 7 years ago

can we add it to the "kraken" org?

vthu commented 7 years ago

It's a yeoman generator which has kraken as a dependency... Though I am not sure what's the best org for this repo

grawk commented 7 years ago

I think that we should add it to the kraken repo, yes.. When it's ready to be "public"

grawk commented 7 years ago

Wondering if we really want to be promoting the ~"react-router"~ "react-engine" pattern, however. There are a lot of other options for server side rendering, and I think ~react-router~ react-engine isn't well maintained at this point.

kentcdodds commented 7 years ago

Actually, react-router is extremely well maintained and the de facto standard for routing in react...

kentcdodds commented 7 years ago

We're you maybe talking about react-engine?

If that's the case then I can't speak to it much as I've never used it, but I can say that I've not seen anyone else use it either...

grawk commented 7 years ago

Yes yes.. react-engine. Not react-router. Anyway, off track for this issue now, but I'm not really sure we want to be promoting react-engine patterns.

vthu commented 7 years ago

I too personally don't like react-engine.. When I coded this generator (way way long back) I didn't know about react-router server side rendering capabilities... Will move this generator to use react-router-redux v5

Thanks for the input... @grawk @kentcdodds

kentcdodds commented 7 years ago

Why redux?

vthu commented 7 years ago

Because project uses redux.. I think it will be good if the routing can be also taken care via redux.. Do you think it's a bad idea?

kentcdodds commented 7 years ago

Yes, I think defaulting to redux is a bad idea in general. Redux is useful in a small handful of use cases and is way overused in the react community. I've had several conversations with Dan (the redux author) and he laments the fact that redux has become so widely overused and encourages people to not use it.

vthu commented 7 years ago

ooh, I will then integrate it with react-router-dom.. i have so much to learn.. Thanks @kentcdodds

DuaneOBrien commented 7 years ago

Hi all. Agree with @grawk - let's move this into the Kraken org once it's ready to go.

Re: reach-engine - @kentcdodds and @grawk if that's not something we should be promoting any further, or if it's not being maintained, we should open a ticket on that repo and start a conversation with Sam about decommissioning it or updating it, whichever makes the most sense. Either of you want to take the lead on that one?

kentcdodds commented 7 years ago

Either of you want to take the lead on that one?

Not me. I've never used it and don't know too much about it... Sorry.

grawk commented 7 years ago

I think it's important to include Sam and/or other users/maintainers of react-engine in the conversation of the "best react pattern" at PayPal. My sense is that the direction doesn't include react-engine. But as it moves forward I'll engage the react-engine team via the repo issues etc.