Closed quicksnap closed 6 years ago
Example of how the current typings would fail:
<Div css={[ { fontSize: 40 }, [ { fontSize: 50 } ] ]} />
Would throw a TS error
@quicksnap Could you rebase (or merge, or whatever to sync with master) this PR?
Done. Hopefully all passes now? =)
In order to automate release, should I adjust my commit message or something?
When you click "Squash and merge" you'll see this which allows you to change the commit message of the squashed commit:
Merging #383 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #383 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 182 182
Branches 52 52
=====================================
Hits 182 182
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a2dcedf...c3b1db9. Read the comment docs.
What:
Fixes the type definitions for
css
prop. Thecss
prop actually accepts either an object or an array of nested objects/arrays.Why: TypeScript support
How: Leverage recursive types described in this comment: https://github.com/Microsoft/TypeScript/issues/3496#issuecomment-128553540
Checklist:
The build fails due to previous failure. I have PR #382 that fixes this.