paypal / glamorous

DEPRECATED: 💄 Maintainable CSS with React
https://glamorous.rocks
MIT License
3.64k stars 208 forks source link

Add CSSFunctions to CSSProperties typings #392

Closed quicksnap closed 6 years ago

quicksnap commented 6 years ago

What:

Improves TypeScript support for CSS functions

codecov-io commented 6 years ago

Codecov Report

Merging #392 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #392   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         177    177           
  Branches       50     50           
=====================================
  Hits          177    177

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a21d8b...7fb508a. Read the comment docs.

quicksnap commented 6 years ago

@luke-john I've added a TypeScript test for this PR.

Let's open separate tickets for the remaining items. If no one picks them up I'll likely take care of them eventually =)

quicksnap commented 6 years ago

Opened #394 for that one.

quicksnap commented 6 years ago

Huh.. I failed the build but I'm not sure why..

quicksnap commented 6 years ago

That same command (npm run validate) passes on my machine.

kentcdodds commented 6 years ago

My guess is there's a transitive dep issue.... May require a kcd-scripts update... I'll look into it when I find time.