paypal / glamorous

DEPRECATED: 💄 Maintainable CSS with React
https://glamorous.rocks
MIT License
3.64k stars 208 forks source link

fix(getGlamorClassName): don't attempt to merge class names that aren't from glamor #415

Closed emmatown closed 6 years ago

emmatown commented 6 years ago

What:

Don't attempt to merge class names that aren't from glamor

Why:

So that if you pass an emotion class name to a glamorous component an error won't be thrown. this CodeSandbox shows what happens without this fix

How:

Check if a class name is on glamor's registered cache before treating it as a glamor class name

Checklist:

kentcdodds commented 6 years ago

I'm not sure why CI is messed up, but I'm going to guess that everything's fine...