search

paypal / here-sideloader-api-samples

Sideloader API samples that enable to integrate PayPal Here into other apps
Other
24 stars 32 forks source link

Callback URL: Tip={Tip} Please distinguish between percentage and monetary amount #13

Closed planetcoops closed 9 years ago

planetcoops commented 9 years ago

From the callback URL we are unable to tell whether the returned Tip is a percentage or a monetary amount.

Is 10.52, 10.52% or 10.52 in currency?

Until this issue is resolved we will have to ignore the returned tip altogether.

jaredegan commented 9 years ago

It is an amount. It's not a percentage. I've updated the docs to be a bit more clear.

planetcoops commented 9 years ago

Hello,

This isn't a doc bug. Try it in PayPal Here. The percentage comes back as the tip.

On Fri, Nov 14, 2014 at 12:53 AM, Jared Egan notifications@github.com wrote:

It is an amount. It's not a percentage. I've updated the docs to be a bit more clear.

— Reply to this email directly or view it on GitHub https://github.com/paypal/here-sideloader-api-samples/issues/13#issuecomment-62994080 .

planetcoops commented 9 years ago

PayPal Here Version 2.3.2 Build 2250

On Fri, Nov 14, 2014 at 12:53 AM, Jared Egan notifications@github.com wrote:

It is an amount. It's not a percentage. I've updated the docs to be a bit more clear.

— Reply to this email directly or view it on GitHub https://github.com/paypal/here-sideloader-api-samples/issues/13#issuecomment-62994080 .

jaredegan commented 9 years ago

OK, it was unclear that you had determined that it was actually the tip percentage getting returned. It turns out that Android & iOS were inconsistent with this field. iOS always returns a total. Android can return a total or a percentage based on what the user does in PPH. Apologies for that. I think the best thing to do at the moment is to continue to ignore it.

Android will be changed to be consistent with iOS and always return the total. This change will be in versions 2.4.1 and above.

planetcoops commented 9 years ago

Thanks. Any provisional time frame for the 2.4.1 release?

On Fri, Nov 14, 2014 at 6:17 PM, Jared Egan notifications@github.com wrote:

OK, it was unclear that you had determined that it was actually the tip percentage getting returned. It turns out that Android & iOS were inconsistent with this field. iOS always returns a total. Android can return a total or a percentage based on what the user does in PPH. Apologies for that. I think the best thing to do at the moment is to continue to ignore it.

Android will be changed to be consistent with iOS and always return the total. This change will be in versions 2.4.1 and above.

— Reply to this email directly or view it on GitHub https://github.com/paypal/here-sideloader-api-samples/issues/13#issuecomment-63106217 .

jaredegan commented 9 years ago

Should be in 1-3 weeks.

planetcoops commented 9 years ago

I confirm that this issue is resolved in the Android version of PPH 2.4.1 Build 2295. Thanks for the fast turn around. Closing issue.